View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001538 | K18X001.00 SKB SWAN | SW | public | 2022-09-16 13:15 | 2023-02-03 15:37 |
| Reporter | (ALTech) Sangmin Choi | Assigned To | Due Date | 2022-09-19 14:12 | |
| Priority | normal | Severity | s4-minor | Reproducibility | N/A |
| Status | closed | Resolution | reopened | ||
| Summary | 0001538: Please apply this patch from BTVV-4698. | ||||
| Description | Please apply this patch from BTVV-4698. | ||||
| Additional Information | https://jira.skbroadband.com/browse/BTVV-4698 | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| User List |
|
|---|
|
|
|
|
|
Hi Sangmin, Done, 2022-09-16 13:40:39 | Tony.Kim@synaptics.. | 8b0a6b7 | syna-release/ampsdk | congested vbi interrupt filtering 2022-09-16 13:40:39 | Tony.Kim@synaptics.. | 893ee44 | syna-release/ampsdk | https://sc-debu-git.synaptics.com/gerrit/ 2022-09-16 13:40:39 | Tony.Kim@synaptics.. | 3da94a7 | syna-release/ampsdk | https://sc-debu-git.synaptics.com/gerrit/ 2022-09-16 13:40:39 | Tony.Kim@synaptics.. | 380a0c4 | syna-release/ampsdk | https://sc-debu-git.synaptics.com/gerrit/ 2022-09-16 13:40:39 | Tony.Kim@synaptics.. | 01fc31b | syna-release/ampsdk | empty_bd_pool crash |
|
|
Hi, Jason, Thank you! |
|
|
Hi, Jason, There was a side effect due to above patches. Synaptics released a patch, please apply attached patch. You don't need to revert above patches. Thank you. 0001-MMCEI-9987-congested-vbi-interrupt-filtering-2.patch (1,959 bytes)
From e50919239f94082182e6e0d6fa2dd2cd253bd718 Mon Sep 17 00:00:00 2001
From: Tony Kim <Tony.Kim@synaptics.com>
Date: Wed, 12 Oct 2022 14:47:57 +0900
Subject: [PATCH] [MMCEI-9987] congested vbi interrupt filtering (2)
Change-Id: Ic28f13d36d69ba3ce448a454b10b27aed4e83285
---
amp/src/hal/vpp/g4_hdr/ca_wrapper/source/vpp_api_tz.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/amp/src/hal/vpp/g4_hdr/ca_wrapper/source/vpp_api_tz.c b/amp/src/hal/vpp/g4_hdr/ca_wrapper/source/vpp_api_tz.c
index 2cd572c..0889acd 100644
--- a/amp/src/hal/vpp/g4_hdr/ca_wrapper/source/vpp_api_tz.c
+++ b/amp/src/hal/vpp/g4_hdr/ca_wrapper/source/vpp_api_tz.c
@@ -112,6 +112,7 @@ int VPP_Suspend_request = 0;
int VPP_Exit_Flag = 0;
int VPP_isr_task_exited = 0;
+static int VPP_playback_started = 0;
/* Static functions */
static HRESULT VPP_ISR_GetMsg(MV_CC_MSG_t * pMsg)
{
@@ -160,7 +161,8 @@ static VOID VPP_ISR_Task(VOID)
vbiDrop = 0;
if (isVBIIntr(msg.m_Param1)){
timeDiff = VPPDRV_vppIntrFreqMonitorGen(VPPDRV_CA_VPPOBJ, VPPDRV_INTR_MONITOR_UINT0_VBI_INTR, VPPDRV_INTR_MONITOR_START, VPPDRV_INTR_MONITOR_NOSHOW);
- if (timeDiff < VPP_MIN_ALLOWED_SCHEDULE_DELAY) {
+ //Allow dropping only after playback is started
+ if (VPP_playback_started && timeDiff < VPP_MIN_ALLOWED_SCHEDULE_DELAY) {
//bCLR_VBI_INTR(msg.m_Param1);
vbiDrop = 1;
printf("%s:%d: Drop VBI interrupt : %x\n", __func__, __LINE__, timeDiff);
@@ -1099,6 +1101,9 @@ INT MV_VPPOBJ_DisplayFrame(INT handle, INT planeID, VOID *frame)
pDesc = (VDEC_VID_BUF_DESC *)frame;
pVBufInfo = pDesc->user_data;
pVBufInfo->m_hDesc = (UINT32)frame;
+ if (!pVBufInfo->builtinFrame) {
+ VPP_playback_started = 1;
+ }
#if 1
if(pVBufInfo->m_dv_present_mode == VPP_DOLBY_PRESENT_BL_EL_METADATA)
{
--
2.7.4
|
|
|
Hi Sangmin, Done, 2022-10-26 09:20:36 | Tony.Kim@synaptics.. | 99db43c | syna-release/ampsdk | congested vbi interrupt filtering (2) |
|
|
Hi, Jason, Thank you! |
|
|
Hi, Jason, There are several side effect due to Synaptics patch and I got the final patch for it. https://synacsm.atlassian.net/servicedesk/customer/portal/173/CSMSKBSBLT-191 Could you please remove and apply patches as follows? 1. remove following commits syna-release/ampsdk 99db43c congested vbi interrupt filtering (2) 8b0a6b7 congested vbi interrupt filtering 3da94a7 https://sc-debu-git.synaptics.com/gerrit/#/c/171604/2 01fc31b empty_bd_pool crash 893ee44 https://sc-debu-git.synaptics.com/gerrit/#/c/171604/ 380a0c4 https://sc-debu-git.synaptics.com/gerrit/#/c/162747/ 2. apply SKBSBLT-191.patch vendor/synaptics/vsxxx Please apply it to 536 branches. Thank you. Sangmin Choi. SKBSBLT-191.patch (3,513 bytes)
diff --git a/interfaces/display/2.1/impl/handlers/BerlinVideoOutput.cpp b/interfaces/display/2.1/impl/handlers/BerlinVideoOutput.cpp
index 291c073..79abb9b 100644
--- a/interfaces/display/2.1/impl/handlers/BerlinVideoOutput.cpp
+++ b/interfaces/display/2.1/impl/handlers/BerlinVideoOutput.cpp
@@ -839,46 +839,46 @@ status_t BerlinVideoOutput::SetDisplayMode(VideoOutputType vout_type,
disp_handle_, AMP_DISP_TG_PRI,
resID, hdmi_vout_config_.bit_depth);
AVS_CHECK(ret, "AMP_DISP_OUT_SetResolution");
- }
- //Vas add modified; River 2021/09/17
-
- AMP_RPC(ret, AMP_DISP_OUT_HDMI_SetVidFmt,
- disp_handle_,
- hdmi_vout_config_.color_format,
- hdmi_vout_config_.bit_depth,
- hdmi_vout_config_.pixel_repetition);
- AVS_CHECK(ret, "AMP_DISP_OUT_HDMI_SetVidFmt");
-
- // only need to check SD resolution
- if (display_mode.width <= 720) {
- for (uint32_t i = 0; i < hdmi_sink_caps_.uiResCnt && i < 64; i++) {
- if (hdmi_sink_caps_.ResInfo[i].ihActive == (int)display_mode.width &&
- hdmi_sink_caps_.ResInfo[i].ivActive == (int)display_mode.height) {
- aspect = hdmi_sink_caps_.ResInfo[i].iAspRatio;
- break;
- }
- }
-
- if (aspect == AMP_DISP_OUT_ASPECT_RATIO_4BY3 ||
- aspect == AMP_DISP_OUT_ASPECT_RATIO_16BY9) {
- // scaninfor unchanged, configure it to -1
- AMP_RPC(ret, AMP_DISP_OUT_HDMI_SetVidInfo, disp_handle_, aspect, -1);
- AVS_CHECK(ret, "AMP_DISP_OUT_HDMI_SetVidInfo");
- }
- }
-
- // Reset HDR enable setting concern the new format support HDR
- ResetHdrSettings();
-
- if (notify) {
- // Check if notify is required
- // We have already notified observers if call from ApplySetting
- value.setString(display_mode.ToString());
- key = AVSettingsHelper::GetFullKey(marvell::kVideoOutputSettingsPrefix,
- marvell::kHDMIDisplayMode);
- av_settings_handle_->NotifyValue(key.string(), value);
- }
-
+ //Vas add modified; River 2021/09/17
+
+ AMP_RPC(ret, AMP_DISP_OUT_HDMI_SetVidFmt,
+ disp_handle_,
+ hdmi_vout_config_.color_format,
+ hdmi_vout_config_.bit_depth,
+ hdmi_vout_config_.pixel_repetition);
+ AVS_CHECK(ret, "AMP_DISP_OUT_HDMI_SetVidFmt");
+
+ // only need to check SD resolution
+ if (display_mode.width <= 720) {
+ for (uint32_t i = 0; i < hdmi_sink_caps_.uiResCnt && i < 64; i++) {
+ if (hdmi_sink_caps_.ResInfo[i].ihActive == (int)display_mode.width &&
+ hdmi_sink_caps_.ResInfo[i].ivActive == (int)display_mode.height) {
+ aspect = hdmi_sink_caps_.ResInfo[i].iAspRatio;
+ break;
+ }
+ }
+
+ if (aspect == AMP_DISP_OUT_ASPECT_RATIO_4BY3 ||
+ aspect == AMP_DISP_OUT_ASPECT_RATIO_16BY9) {
+ // scaninfor unchanged, configure it to -1
+ AMP_RPC(ret, AMP_DISP_OUT_HDMI_SetVidInfo, disp_handle_, aspect, -1);
+ AVS_CHECK(ret, "AMP_DISP_OUT_HDMI_SetVidInfo");
+ }
+ }
+
+ // Reset HDR enable setting concern the new format support HDR
+ ResetHdrSettings();
+
+ if (notify) {
+ // Check if notify is required
+ // We have already notified observers if call from ApplySetting
+ value.setString(display_mode.ToString());
+ key = AVSettingsHelper::GetFullKey(marvell::kVideoOutputSettingsPrefix,
+ marvell::kHDMIDisplayMode);
+ av_settings_handle_->NotifyValue(key.string(), value);
+ }
+ }
+
AVS_FUNC_LEAVE
return android::OK;
|
|
|
Hi, Dean, Please use following commit message for SKBSBLT-191.patch. [BTVV-4698] fix msync failure while standby/wakeup testing. msync failure could make ampservice crash or pipeline halted. Thank you. Sangmin. |
|
|
Hi Sangmin, Done. 2023-02-03 14:57:36 | dean.ty.chiang@mai.. | 6001ed6 | vendor/synaptics/vsxxx | [BTVV-4698] fix msync failure while standby/wakeup testing. msync failure cou 2023-02-03 13:50:51 | dean.ty.chiang@mai.. | 1ea2c96 | syna-release/ampsdk | Revert "https://sc-debu-git.synaptics.com/gerrit/ 2023-02-03 13:50:37 | dean.ty.chiang@mai.. | 92208d1 | syna-release/ampsdk | Revert "https://sc-debu-git.synaptics.com/gerrit/ 2023-02-03 13:50:26 | dean.ty.chiang@mai.. | db94962 | syna-release/ampsdk | Revert "empty_bd_pool crash" 2023-02-03 13:49:19 | dean.ty.chiang@mai.. | f06bc0f | syna-release/ampsdk | Revert "https://sc-debu-git.synaptics.com/gerrit/ 2023-02-03 13:48:51 | dean.ty.chiang@mai.. | 861a30a | syna-release/ampsdk | Revert "congested vbi interrupt filtering" 2023-02-03 13:48:23 | dean.ty.chiang@mai.. | 155dc5a | syna-release/ampsdk | Revert "congested vbi interrupt filtering (2)" |
|
|
Hi, Dean, Thank you! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-09-16 13:15 | (ALTech) Sangmin Choi | New Issue | |
| 2022-09-16 13:15 | (ALTech) Sangmin Choi | Status | new => assigned |
| 2022-09-16 13:15 | (ALTech) Sangmin Choi | Assigned To | => (SW) Jason Ling |
| 2022-09-16 13:15 | (ALTech) Sangmin Choi | File Added: MMCEI-9987_SKBSBLT-191_patch (1).zip | |
| 2022-09-16 13:41 |
|
Note Added: 0010877 | |
| 2022-09-16 13:41 |
|
Assigned To | (SW) Jason Ling => (ALTech) Sangmin Choi |
| 2022-09-16 13:42 |
|
Status | assigned => resolved |
| 2022-09-16 13:42 |
|
Resolution | open => fixed |
| 2022-09-16 14:09 | (ALTech) Sangmin Choi | Status | resolved => closed |
| 2022-09-16 14:09 | (ALTech) Sangmin Choi | Note Added: 0010878 | |
| 2022-10-26 08:39 | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi => (SW) Jason Ling |
| 2022-10-26 08:39 | (ALTech) Sangmin Choi | Status | closed => feedback |
| 2022-10-26 08:39 | (ALTech) Sangmin Choi | Resolution | fixed => reopened |
| 2022-10-26 08:48 | (ALTech) Sangmin Choi | Note Added: 0011106 | |
| 2022-10-26 08:48 | (ALTech) Sangmin Choi | File Added: 0001-MMCEI-9987-congested-vbi-interrupt-filtering-2.patch | |
| 2022-10-26 08:48 | (ALTech) Sangmin Choi | Status | feedback => assigned |
| 2022-10-26 09:22 |
|
Assigned To | (SW) Jason Ling => (ALTech) Sangmin Choi |
| 2022-10-26 09:22 |
|
Status | assigned => resolved |
| 2022-10-26 09:22 |
|
Resolution | reopened => fixed |
| 2022-10-26 09:22 |
|
Note Added: 0011107 | |
| 2022-10-26 09:42 | (ALTech) Sangmin Choi | Note Added: 0011109 | |
| 2022-10-26 09:42 | (ALTech) Sangmin Choi | Status | resolved => closed |
| 2023-02-03 13:25 | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi => (SW) Jason Ling |
| 2023-02-03 13:25 | (ALTech) Sangmin Choi | Status | closed => feedback |
| 2023-02-03 13:25 | (ALTech) Sangmin Choi | Resolution | fixed => reopened |
| 2023-02-03 13:26 | (ALTech) Sangmin Choi | Note Added: 0011994 | |
| 2023-02-03 13:26 | (ALTech) Sangmin Choi | File Added: SKBSBLT-191.patch | |
| 2023-02-03 13:26 | (ALTech) Sangmin Choi | Status | feedback => assigned |
| 2023-02-03 13:26 | (ALTech) Sangmin Choi | Issue Monitored: (SW) Jim Chen | |
| 2023-02-03 13:27 | (ALTech) Sangmin Choi | Issue Monitored: (SW) Dean Chiang | |
| 2023-02-03 13:45 |
|
Assigned To | (SW) Jason Ling => (SW) Dean Chiang |
| 2023-02-03 14:55 | (ALTech) Sangmin Choi | Note Added: 0011995 | |
| 2023-02-03 15:05 |
|
Note Added: 0011996 | |
| 2023-02-03 15:36 | (ALTech) Sangmin Choi | Note Added: 0011998 | |
| 2023-02-03 15:37 | (ALTech) Sangmin Choi | Status | assigned => closed |